Skip to content

Conversation

jakebailey
Copy link
Member

See microsoft/TypeScript#62501 (comment). This fixes a bug that caused issues with WalkOptions discrimination, caught by typescript-go.

@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 29, 2025

@jakebailey Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73777,
  "author": "jakebailey",
  "headCommitOid": "7545500fbd1dffc6de25688cb57770497de94832",
  "mergeBaseOid": "9b7786702ab15b88f7b77e5bad5cbd35be07d938",
  "lastPushDate": "2025-09-29T20:27:07.000Z",
  "lastActivityDate": "2025-09-29T20:27:07.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "css-tree",
      "kind": "edit",
      "files": [
        {
          "path": "types/css-tree/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "erik-kallen",
        "pyoor"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3348931598,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Sep 29, 2025
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Sep 29, 2025
@typescript-bot
Copy link
Contributor

🔔 @erik-kallen @pyoor — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Sep 29, 2025
@jakebailey jakebailey merged commit 8ddf18f into DefinitelyTyped:master Sep 29, 2025
4 checks passed
@jakebailey jakebailey deleted the fix-css-types branch September 29, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants