Skip to content
This repository was archived by the owner on Jul 1, 2024. It is now read-only.

Commit bbdea69

Browse files
committed
Better approach for making the welcome comment first
The last thing is not enough, since the label & column changes takes a good amount of vertical space in the timeline rendering. (And one more random tweak.)
1 parent 024d887 commit bbdea69

File tree

79 files changed

+608
-601
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+608
-601
lines changed

β€Žsrc/_tests/fixtures/38979/mutations.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
[
2+
{
3+
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}\n",
4+
"variables": {
5+
"input": {
6+
"id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxMg==",
7+
"body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` β€” [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=38979&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days β€” it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
8+
}
9+
}
10+
},
211
{
312
"mutation": "mutation ($input: AddLabelsToLabelableInput!) {\n addLabelsToLabelable(input: $input) {\n __typename\n }\n}\n",
413
"variables": {
@@ -32,15 +41,6 @@
3241
}
3342
}
3443
},
35-
{
36-
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}\n",
37-
"variables": {
38-
"input": {
39-
"id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxMg==",
40-
"body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` β€” [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=38979&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days β€” it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
41-
}
42-
}
43-
},
4444
{
4545
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
4646
"variables": {

β€Žsrc/_tests/fixtures/43136/mutations.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
[
2+
{
3+
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
4+
"variables": {
5+
"input": {
6+
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4MzgyMzYy",
7+
"body": "@larsrh Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `estree` β€” [on npm](https://www.npmjs.com/package/estree), [on unpkg](https://unpkg.com/browse/estree@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43136&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
8+
}
9+
}
10+
},
211
{
312
"mutation": "mutation ($input: AddLabelsToLabelableInput!) {\n addLabelsToLabelable(input: $input) {\n __typename\n }\n}\n",
413
"variables": {
@@ -31,15 +40,6 @@
3140
}
3241
}
3342
},
34-
{
35-
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
36-
"variables": {
37-
"input": {
38-
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4MzgyMzYy",
39-
"body": "@larsrh Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `estree` β€” [on npm](https://www.npmjs.com/package/estree), [on unpkg](https://unpkg.com/browse/estree@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43136&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
40-
}
41-
}
42-
},
4343
{
4444
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
4545
"variables": {

β€Žsrc/_tests/fixtures/43144/mutations.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
[
2+
{
3+
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
4+
"variables": {
5+
"input": {
6+
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4NDkxOTI2",
7+
"body": "@jeffreymeng Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `mailcheck` β€” [on npm](https://www.npmjs.com/package/mailcheck), [on unpkg](https://unpkg.com/browse/mailcheck@latest/)\n - owner-approval: @pocesar\n\n## Code Reviews\n\nBecause you edited one package and updated the tests (πŸ‘), I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43144&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * βœ… Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
8+
}
9+
}
10+
},
211
{
312
"mutation": "mutation ($input: AddLabelsToLabelableInput!) {\n addLabelsToLabelable(input: $input) {\n __typename\n }\n}\n",
413
"variables": {
@@ -19,15 +28,6 @@
1928
}
2029
}
2130
},
22-
{
23-
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
24-
"variables": {
25-
"input": {
26-
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4NDkxOTI2",
27-
"body": "@jeffreymeng Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `mailcheck` β€” [on npm](https://www.npmjs.com/package/mailcheck), [on unpkg](https://unpkg.com/browse/mailcheck@latest/)\n - owner-approval: @pocesar\n\n## Code Reviews\n\nBecause you edited one package and updated the tests (πŸ‘), I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43144&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * βœ… Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
28-
}
29-
}
30-
},
3131
{
3232
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
3333
"variables": {

β€Žsrc/_tests/fixtures/43151/mutations.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
[
2+
{
3+
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
4+
"variables": {
5+
"input": {
6+
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5",
7+
"body": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) β€” [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43151&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
8+
}
9+
}
10+
},
211
{
312
"mutation": "mutation ($input: RemoveLabelsFromLabelableInput!) {\n removeLabelsFromLabelable(input: $input) {\n __typename\n }\n}\n",
413
"variables": {
@@ -19,15 +28,6 @@
1928
}
2029
}
2130
},
22-
{
23-
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
24-
"variables": {
25-
"input": {
26-
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5",
27-
"body": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) β€” [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43151&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
28-
}
29-
}
30-
},
3131
{
3232
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
3333
"variables": {

β€Žsrc/_tests/fixtures/43160/mutations.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
[
2+
{
3+
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
4+
"variables": {
5+
"input": {
6+
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5MDYwOTQ4",
7+
"body": "@rikkertkoppes Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `dagre` β€” [on npm](https://www.npmjs.com/package/dagre), [on unpkg](https://unpkg.com/browse/dagre@latest/)\n - owner-approval: @rustedgrail\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43160&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * ❌ Continuous integration tests have failed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
8+
}
9+
}
10+
},
211
{
312
"mutation": "mutation ($input: AddLabelsToLabelableInput!) {\n addLabelsToLabelable(input: $input) {\n __typename\n }\n}\n",
413
"variables": {
@@ -19,15 +28,6 @@
1928
}
2029
}
2130
},
22-
{
23-
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
24-
"variables": {
25-
"input": {
26-
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5MDYwOTQ4",
27-
"body": "@rikkertkoppes Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `dagre` β€” [on npm](https://www.npmjs.com/package/dagre), [on unpkg](https://unpkg.com/browse/dagre@latest/)\n - owner-approval: @rustedgrail\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43160&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * ❌ Continuous integration tests have failed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
28-
}
29-
}
30-
},
3131
{
3232
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
3333
"variables": {

β€Žsrc/_tests/fixtures/43160/result.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66
"Untested Change"
77
],
88
"responseComments": [
9-
{
10-
"tag": "welcome",
11-
"status": "@rikkertkoppes Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `dagre` β€” [on npm](https://www.npmjs.com/package/dagre), [on unpkg](https://unpkg.com/browse/dagre@latest/)\n - owner-approval: @rustedgrail\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43160&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * ❌ Continuous integration tests have failed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
12-
},
139
{
1410
"tag": "suggest-testing",
1511
"status": "Hey @rikkertkoppes,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***"
1612
},
13+
{
14+
"tag": "welcome",
15+
"status": "@rikkertkoppes Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `dagre` β€” [on npm](https://www.npmjs.com/package/dagre), [on unpkg](https://unpkg.com/browse/dagre@latest/)\n - owner-approval: @rustedgrail\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43160&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * ❌ Continuous integration tests have failed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
16+
},
1717
{
1818
"tag": "gh-actions-complaint-6d5d2a8",
1919
"status": "@rikkertkoppes The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/22c73c88cc9c09efd4c2998ec360607dd4c36c2e/checks?check_suite_id=731664306).\n\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!\n\n**Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.**"

0 commit comments

Comments
Β (0)