Skip to content
This repository was archived by the owner on Jul 1, 2024. It is now read-only.

Commit cac40d9

Browse files
elibarzilayelibarzilay
committed
Improve RemindPeopleTheyCanUnblockPR
When the CI is not passing, it seems weird to tell people that they can short-circuit waiting for a maintainer. But it'll be bad to drop the comment altogether in this case: this will let people fix the CI and only then bug them about adding a test, so they'll be much less inclinded to do so. Instead, have a different phrasing for the failing CI case.
1 parent a3d2316 commit cac40d9

File tree

14 files changed

+484
-14
lines changed

14 files changed

+484
-14
lines changed

‎src/_tests/fixtures/51338/mutations.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"variables": {
2525
"input": {
2626
"subjectId": "MDExOlB1bGxSZXF1ZXN0NTc2NTk4OTQ2",
27-
"body": ":hourglass_flowing_sand: Hi @pkuczynski,\n\nIt's been a few days since this PR was approved by tellnes and we're waiting on a DT maintainer to give a review.\n\nIf you would like to short-circuit this wait, you can edit some of the [test files](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-my-package-teststs) in the package which verify how the `.d.ts` files work. This would allow the PR to be merged by you or the DT module owners after a re-review.\n<!--typescript_bot_wait-for-merge-offer-4a7712f-->"
27+
"body": ":hourglass_flowing_sand: Hi @pkuczynski,\n\nIt's been a few days since this PR was approved by tellnes and we're waiting for a DT maintainer to give a review.\n\nIf you would like to short-circuit this wait, you can edit some of the [test files](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-my-package-teststs) in the package which verify how the `.d.ts` files work. This would allow the PR to be merged by you or the DT module owners after a re-review.\n<!--typescript_bot_wait-for-merge-offer-4a7712f-->"
2828
}
2929
}
3030
},

‎src/_tests/fixtures/51338/result.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
},
2020
{
2121
"tag": "wait-for-merge-offer-4a7712f",
22-
"status": ":hourglass_flowing_sand: Hi @pkuczynski,\n\nIt's been a few days since this PR was approved by tellnes and we're waiting on a DT maintainer to give a review.\n\nIf you would like to short-circuit this wait, you can edit some of the [test files](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-my-package-teststs) in the package which verify how the `.d.ts` files work. This would allow the PR to be merged by you or the DT module owners after a re-review."
22+
"status": ":hourglass_flowing_sand: Hi @pkuczynski,\n\nIt's been a few days since this PR was approved by tellnes and we're waiting for a DT maintainer to give a review.\n\nIf you would like to short-circuit this wait, you can edit some of the [test files](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-my-package-teststs) in the package which verify how the `.d.ts` files work. This would allow the PR to be merged by you or the DT module owners after a re-review."
2323
},
2424
{
2525
"tag": "Unreviewed:nearly:2021-02-19",

‎src/_tests/fixtures/55035/_downloads.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"jsreport-core": 5044
3+
}

‎src/_tests/fixtures/55035/_files.json

Lines changed: 4 additions & 0 deletions
Large diffs are not rendered by default.

‎src/_tests/fixtures/55035/_response.json

Lines changed: 347 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,347 @@
1+
{
2+
"data": {
3+
"repository": {
4+
"id": "MDEwOlJlcG9zaXRvcnk2MDkzMzE2",
5+
"pullRequest": {
6+
"id": "MDExOlB1bGxSZXF1ZXN0NzA2NjY4NDgw",
7+
"title": "Add missing document store functions",
8+
"createdAt": "2021-08-09T16:31:15Z",
9+
"author": {
10+
"login": "shoopapa",
11+
"__typename": "User"
12+
},
13+
"authorAssociation": "FIRST_TIME_CONTRIBUTOR",
14+
"baseRef": {
15+
"name": "master",
16+
"__typename": "Ref"
17+
},
18+
"labels": {
19+
"nodes": [
20+
{
21+
"name": "Other Approved",
22+
"__typename": "Label"
23+
},
24+
{
25+
"name": "Abandoned",
26+
"__typename": "Label"
27+
},
28+
{
29+
"name": "Owner Approved",
30+
"__typename": "Label"
31+
},
32+
{
33+
"name": "The CI failed",
34+
"__typename": "Label"
35+
},
36+
{
37+
"name": "Untested Change",
38+
"__typename": "Label"
39+
}
40+
],
41+
"__typename": "LabelConnection"
42+
},
43+
"isDraft": false,
44+
"mergeable": "MERGEABLE",
45+
"number": 55035,
46+
"state": "OPEN",
47+
"headRefOid": "7eca0aa421c535497e59aa231b955ea2b47712e4",
48+
"changedFiles": 1,
49+
"timelineItems": {
50+
"nodes": [
51+
{
52+
"actor": {
53+
"login": "typescript-bot",
54+
"__typename": "User"
55+
},
56+
"createdAt": "2021-08-09T16:36:55Z",
57+
"projectColumnName": "Needs Author Action",
58+
"__typename": "MovedColumnsInProjectEvent"
59+
},
60+
{
61+
"actor": {
62+
"login": "typescript-bot",
63+
"__typename": "User"
64+
},
65+
"createdAt": "2021-08-10T17:10:55Z",
66+
"projectColumnName": "Waiting for Code Reviews",
67+
"__typename": "MovedColumnsInProjectEvent"
68+
},
69+
{
70+
"actor": {
71+
"login": "typescript-bot",
72+
"__typename": "User"
73+
},
74+
"createdAt": "2021-08-10T17:15:39Z",
75+
"projectColumnName": "Needs Author Action",
76+
"__typename": "MovedColumnsInProjectEvent"
77+
}
78+
],
79+
"__typename": "PullRequestTimelineItemsConnection"
80+
},
81+
"reviews": {
82+
"nodes": [
83+
{
84+
"author": {
85+
"login": "kkikta-bcg",
86+
"__typename": "User"
87+
},
88+
"commit": {
89+
"oid": "7eca0aa421c535497e59aa231b955ea2b47712e4",
90+
"__typename": "Commit"
91+
},
92+
"comments": {
93+
"nodes": [],
94+
"__typename": "PullRequestReviewCommentConnection"
95+
},
96+
"authorAssociation": "NONE",
97+
"state": "APPROVED",
98+
"submittedAt": "2021-08-13T18:37:59Z",
99+
"url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/55035#pullrequestreview-729879946",
100+
"__typename": "PullRequestReview"
101+
},
102+
{
103+
"author": {
104+
"login": "newbish",
105+
"__typename": "User"
106+
},
107+
"commit": {
108+
"oid": "7eca0aa421c535497e59aa231b955ea2b47712e4",
109+
"__typename": "Commit"
110+
},
111+
"comments": {
112+
"nodes": [],
113+
"__typename": "PullRequestReviewCommentConnection"
114+
},
115+
"authorAssociation": "CONTRIBUTOR",
116+
"state": "APPROVED",
117+
"submittedAt": "2021-08-13T18:40:30Z",
118+
"url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/55035#pullrequestreview-729881642",
119+
"__typename": "PullRequestReview"
120+
},
121+
{
122+
"author": {
123+
"login": "pofider",
124+
"__typename": "User"
125+
},
126+
"commit": {
127+
"oid": "7eca0aa421c535497e59aa231b955ea2b47712e4",
128+
"__typename": "Commit"
129+
},
130+
"comments": {
131+
"nodes": [],
132+
"__typename": "PullRequestReviewCommentConnection"
133+
},
134+
"authorAssociation": "CONTRIBUTOR",
135+
"state": "APPROVED",
136+
"submittedAt": "2021-08-16T10:04:47Z",
137+
"url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/55035#pullrequestreview-730538734",
138+
"__typename": "PullRequestReview"
139+
}
140+
],
141+
"__typename": "PullRequestReviewConnection"
142+
},
143+
"commits": {
144+
"totalCount": 2,
145+
"nodes": [
146+
{
147+
"commit": {
148+
"checkSuites": {
149+
"nodes": [
150+
{
151+
"databaseId": 3460073804,
152+
"app": {
153+
"name": "GitHub Actions",
154+
"__typename": "App"
155+
},
156+
"conclusion": "FAILURE",
157+
"resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/7eca0aa421c535497e59aa231b955ea2b47712e4/checks?check_suite_id=3460073804",
158+
"status": "COMPLETED",
159+
"url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/7eca0aa421c535497e59aa231b955ea2b47712e4/checks?check_suite_id=3460073804",
160+
"checkRuns": {
161+
"nodes": [
162+
{
163+
"title": "test",
164+
"__typename": "CheckRun"
165+
}
166+
],
167+
"__typename": "CheckRunConnection"
168+
},
169+
"__typename": "CheckSuite"
170+
},
171+
{
172+
"databaseId": 3460076596,
173+
"app": {
174+
"name": "Azure Pipelines",
175+
"__typename": "App"
176+
},
177+
"conclusion": "FAILURE",
178+
"resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/7eca0aa421c535497e59aa231b955ea2b47712e4/checks?check_suite_id=3460076596",
179+
"status": "COMPLETED",
180+
"url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/7eca0aa421c535497e59aa231b955ea2b47712e4/checks?check_suite_id=3460076596",
181+
"checkRuns": {
182+
"nodes": [
183+
{
184+
"title": "Build #20210810.42 failed",
185+
"__typename": "CheckRun"
186+
}
187+
],
188+
"__typename": "CheckRunConnection"
189+
},
190+
"__typename": "CheckSuite"
191+
}
192+
],
193+
"__typename": "CheckSuiteConnection"
194+
},
195+
"status": null,
196+
"authoredDate": "2021-08-10T17:10:10Z",
197+
"committedDate": "2021-08-10T17:10:10Z",
198+
"pushedDate": "2021-08-10T17:10:15Z",
199+
"oid": "7eca0aa421c535497e59aa231b955ea2b47712e4",
200+
"__typename": "Commit"
201+
},
202+
"__typename": "PullRequestCommit"
203+
}
204+
],
205+
"__typename": "PullRequestCommitConnection"
206+
},
207+
"comments": {
208+
"totalCount": 6,
209+
"nodes": [
210+
{
211+
"id": "IC_kwDOAFz6BM41Xjgt",
212+
"author": {
213+
"login": "typescript-bot",
214+
"__typename": "User"
215+
},
216+
"databaseId": 895367213,
217+
"body": "@shoopapa Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jsreport-core` — [on npm](https://www.npmjs.com/package/jsreport-core), [on unpkg](https://unpkg.com/browse/jsreport-core@latest/)\n - owner-approval: @pofider, @newbish\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=55035&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 24 days — it is considered nearly abandoned!\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->",
218+
"createdAt": "2021-08-09T16:31:54Z",
219+
"reactions": {
220+
"nodes": [],
221+
"__typename": "ReactionConnection"
222+
},
223+
"__typename": "IssueComment"
224+
},
225+
{
226+
"id": "IC_kwDOAFz6BM41XjhS",
227+
"author": {
228+
"login": "typescript-bot",
229+
"__typename": "User"
230+
},
231+
"databaseId": 895367250,
232+
"body": "Hey @shoopapa,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***\n<!--typescript_bot_suggest-testing-->",
233+
"createdAt": "2021-08-09T16:31:56Z",
234+
"reactions": {
235+
"nodes": [],
236+
"__typename": "ReactionConnection"
237+
},
238+
"__typename": "IssueComment"
239+
},
240+
{
241+
"id": "IC_kwDOAFz6BM41XjhY",
242+
"author": {
243+
"login": "typescript-bot",
244+
"__typename": "User"
245+
},
246+
"databaseId": 895367256,
247+
"body": "🔔 @taoqf @pofider @newbish — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/55035/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on.\n<!--typescript_bot_pinging-reviewers-->",
248+
"createdAt": "2021-08-09T16:31:57Z",
249+
"reactions": {
250+
"nodes": [],
251+
"__typename": "ReactionConnection"
252+
},
253+
"__typename": "IssueComment"
254+
},
255+
{
256+
"id": "IC_kwDOAFz6BM41XkVT",
257+
"author": {
258+
"login": "typescript-bot",
259+
"__typename": "User"
260+
},
261+
"databaseId": 895370579,
262+
"body": "@shoopapa The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/d05a3553812b8bbddc4d3ad3aab8933df5b011a3/checks?check_suite_id=3449794103).\n\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!\n\n**Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.**\n<!--typescript_bot_gh-actions-complaint-d05a355-->",
263+
"createdAt": "2021-08-09T16:36:56Z",
264+
"reactions": {
265+
"nodes": [],
266+
"__typename": "ReactionConnection"
267+
},
268+
"__typename": "IssueComment"
269+
},
270+
{
271+
"id": "IC_kwDOAFz6BM41amij",
272+
"author": {
273+
"login": "typescript-bot",
274+
"__typename": "User"
275+
},
276+
"databaseId": 896166051,
277+
"body": "@shoopapa The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/7eca0aa421c535497e59aa231b955ea2b47712e4/checks?check_suite_id=3460073804).\n\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!\n\n**Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.**\n<!--typescript_bot_gh-actions-complaint-7eca0aa-->",
278+
"createdAt": "2021-08-10T17:15:40Z",
279+
"reactions": {
280+
"nodes": [],
281+
"__typename": "ReactionConnection"
282+
},
283+
"__typename": "IssueComment"
284+
},
285+
{
286+
"id": "IC_kwDOAFz6BM42jTf-",
287+
"author": {
288+
"login": "typescript-bot",
289+
"__typename": "User"
290+
},
291+
"databaseId": 915224574,
292+
"body": "@shoopapa I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Sep 15th (in a week) if the issues aren't addressed.\n<!--typescript_bot_Abandoned:nearly:2021-08-16-->",
293+
"createdAt": "2021-09-08T13:09:18Z",
294+
"reactions": {
295+
"nodes": [],
296+
"__typename": "ReactionConnection"
297+
},
298+
"__typename": "IssueComment"
299+
}
300+
],
301+
"__typename": "IssueCommentConnection"
302+
},
303+
"files": {
304+
"totalCount": 1,
305+
"nodes": [
306+
{
307+
"path": "types/jsreport-core/index.d.ts",
308+
"additions": 2,
309+
"deletions": 0,
310+
"__typename": "PullRequestChangedFile"
311+
}
312+
],
313+
"pageInfo": {
314+
"hasNextPage": false,
315+
"endCursor": "MQ",
316+
"__typename": "PageInfo"
317+
},
318+
"__typename": "PullRequestChangedFileConnection"
319+
},
320+
"projectCards": {
321+
"nodes": [
322+
{
323+
"id": "PRC_lALOAFz6BM4AORWwzgP24_0",
324+
"project": {
325+
"id": "MDc6UHJvamVjdDM3NDExMDQ=",
326+
"number": 5,
327+
"name": "New Pull Request Status Board",
328+
"__typename": "Project"
329+
},
330+
"column": {
331+
"id": "MDEzOlByb2plY3RDb2x1bW43NTUyOTI0",
332+
"name": "Needs Author Action",
333+
"__typename": "ProjectColumn"
334+
},
335+
"__typename": "ProjectCard"
336+
}
337+
],
338+
"__typename": "ProjectCardConnection"
339+
},
340+
"__typename": "PullRequest"
341+
},
342+
"__typename": "Repository"
343+
}
344+
},
345+
"loading": false,
346+
"networkStatus": 7
347+
}

0 commit comments

Comments
 (0)