Skip to content

restore ec module legacy pinpok due to bugs with new approach #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FlorisBuwaldaDeltares wants to merge 2 commits into
base: main
Choose a base branch
from
Open

restore ec module legacy pinpok due to bugs with new approach #510

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5239eb
restore ec module legacy pinpok due to bugs with new approach
FlorisBuwaldaDeltares Jan 20, 2026
c0382c8
add more missing use statements
FlorisBuwaldaDeltares Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/utils_lgpl/ec_module/packages/ec_module/src/ec_basic_interpolation.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,12 @@ module m_ec_basic_interpolation

use precision, only : sp, hp
use MessageHandling, only: msgbox, mess, LEVEL_ERROR
use geometry_module
use geometry_module, only: dbdistance, getdx, getdy, vecprod, inprod, pinpok_legacy, pinpok3D, dbpinpol, ave3d, gaussj, getdxdy, cross, cross3D, SPHERTOCART3D
use m_ec_triangle
use m_ec_interpolationsettings
use mathconsts, only: degrad_hp
use kdtree2Factory
use m_alloc, only : aerr, realloc
!use gridgeom

interface triinterp2
module procedure triinterp2_dbldbl
Expand Down Expand Up @@ -936,7 +935,7 @@ subroutine findtri_kdtree(XP,YP,ZP,XS,YS,ZS,NS,NDIM,NRFIND,INTRI,JSLO,SLO,JATEK,
else
numsearched = numsearched+1
if ( jasfer3D == 0 ) then
call pinpok(xp,yp,3,xv,yv,intri, jins, dmiss)
call pinpok_legacy(xp,yp,3,xv,yv,intri, jins, dmiss)
else
call pinpok3D(xp,yp,3,xv,yv,intri, dmiss, jins, 1, 1, dfac=dfac, xz=xz, yz=yz)
end if
Expand Down Expand Up @@ -1084,7 +1083,7 @@ subroutine FINDTRI(XP,YP,ZP,XS,YS,ZS,NDIM,NRFIND,INTRI,JSLO,SLO,JATEK, ind, wf,
YTMIN = MIN(YT(1),MIN( YT(2),YT(3) ) )
IF (XP >= XTMIN .AND. XP <= XTMAX .AND. &
YP >= YTMIN .AND. YP <= YTMAX) THEN
CALL PINPOK(XP,YP,3,XT,YT,INTRI, jins, dmiss)
CALL PINPOK_LEGACY(XP,YP,3,XT,YT,INTRI, jins, dmiss)
IF (INTRI == 1) THEN
NRFIND = K
NROLDFIND = NRFIND
Expand Down Expand Up @@ -1751,7 +1750,7 @@ subroutine averaging2(ndim,ns,xs,ys,zss,ipsam,xc,yc,zc,grid_width,xx,yy,n6,nnn,j
end do

if (ys(k) >= ylow .and. ys(k) <= yhih) then
call pinpok(xs(k), ys(k), nn, xh, yh, inhul, jins, dmiss)
call pinpok_legacy(xs(k), ys(k), nn, xh, yh, inhul, jins, dmiss)
if (inhul == 1) then
do ivar = 1, ndim
select case (iav)
Expand Down