Skip to content

UNST-9564: connect bubble screen to ec module#555

Open
mihai-pricope wants to merge 11 commits intomainfrom
all/feature/UNST-9564_connect_bubble_screen_to_ec_module
Open

UNST-9564: connect bubble screen to ec module#555
mihai-pricope wants to merge 11 commits intomainfrom
all/feature/UNST-9564_connect_bubble_screen_to_ec_module

Conversation

@mihai-pricope
Copy link
Contributor

@mihai-pricope mihai-pricope commented Jan 30, 2026

What was done

alloc all sourcesink objects before so that ecModule pointers remain valid
connect only the first bubble screen source sink to ecModule to write the air discharge in qstss

Evidence of the work done

  • Video/figures
 Bubblescreen bubbles1 total discharge at time    900.000000000000       is 
   204.166666665697     
 Bubblescreen bubbles1 total discharge at time    1200.00000000000       is 
   205.555555556202     
 Bubblescreen bubbles1 total discharge at time    1500.00000000000       is 
   206.944444443798     
 Bubblescreen bubbles1 total discharge at time    1800.00000000000       is 
   208.333333334303    

  • Clear from the issue description
  • Not applicable

Tests

  • Tests updated
    <add testcase numbers if applicable, Issue number>
  • [X ] Not applicable

Documentation

  • Documentation updated
    <add description of changes if applicable, Issue number>
  • [ X] Not applicable

Issue link

https://issuetracker.deltares.nl/browse/UNST-9564

Copy link
Contributor

@thomas-pijls thomas-pijls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mihai-pricope mihai-pricope enabled auto-merge (squash) February 2, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants