UNST-9565: Implement bubble screen in dflowfm kernel#557
Open
thomas-pijls wants to merge 20 commits intomainfrom
Open
UNST-9565: Implement bubble screen in dflowfm kernel#557thomas-pijls wants to merge 20 commits intomainfrom
thomas-pijls wants to merge 20 commits intomainfrom
Conversation
…n_in_dflowfm_kernel
…n_in_dflowfm_kernel
…nd compute_discharge_vertical_distribution
…ges for bubble screens
…n_in_dflowfm_kernel
…me in compute_constituent_discharge subroutine
…n_in_dflowfm_kernel
…n_in_dflowfm_kernel
…m_kernel' of https://github.com/Deltares/Delft3D into all/feature/UNST-9565_implement_bubble_screen_in_dflowfm_kernel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
Implementation of bubble screens in the dflowfm kernel, based on the D3D4 implementation (see
z_disbub.f90anddisbub.f90).DONE:
TODO:
Evidence of the work done
<add video/figures if applicable>
Tests
Documentation
<add description of changes if applicable, Issue number>
Issue link