Waq/bugfix/delwaq 1232 improve settling deposition#561
Open
arjenmarkusdeltaresnl wants to merge 6 commits intomainfrom
Open
Waq/bugfix/delwaq 1232 improve settling deposition#561arjenmarkusdeltaresnl wants to merge 6 commits intomainfrom
arjenmarkusdeltaresnl wants to merge 6 commits intomainfrom
Conversation
The code at present is very specific to the "depos" test case. It should be made more general. See the comments at the issue though.
To check if the principle works for another kind of (idealised) model, I applied it to a column model with 20 segments. Again, this is not definitive but the results are encouraging.
The proof of concept was geared to two tiny model set-ups. This commit tries to make the idea general. For this several extra parameters are required in the process configuration. Special attention is needed for the estimate of the maximum flux - do we get all the signs and the indices right?
…ass that can be deposited per time step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
Evidence of the work done
<add video/figures if applicable>
Tests
<add testcase numbers if applicable, Issue number>
Documentation
<add description of changes if applicable, Issue number>
Issue link