Add .clang-tidy from Water Quality team, add Readme on how to add it …#579
Open
harmenwierenga wants to merge 1 commit intomainfrom
Open
Add .clang-tidy from Water Quality team, add Readme on how to add it …#579harmenwierenga wants to merge 1 commit intomainfrom
harmenwierenga wants to merge 1 commit intomainfrom
Conversation
adrimourits
approved these changes
Feb 6, 2026
| Go to the C++ project (csumo_precice) in the solution explorer, right click and go to Properties, | ||
| or click on the project and go to Project -> Properties. | ||
| Then, find Code Analysis -> General -> Enable Clang Tidy and set it to 'Yes.' | ||
| It will automatically use the settings from the Visual Studio solution, and also find the project headers. |
Contributor
There was a problem hiding this comment.
It's a pitty that this change disappears when redoing cmake config. I'm in favour of adding it to the CMake file, but that might be too invasive (and also needs an updated CMake version?). I can live with how it is in this branch.
| @@ -1,4 +1,4 @@ | |||
| # Set up C++ Formatting | |||
| # Set up clang-format C++ Formatting | |||
Contributor
There was a problem hiding this comment.
How do we avoid flip-flopping when one developer uses tidy and another not?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to your IDE
What was done
Evidence of the work done
<add video/figures if applicable>
Tests
<add testcase numbers if applicable, Issue number>
Documentation
<add description of changes if applicable, Issue number>
Issue link UNST-9604