Skip to content

chore: #710 make analysis settings private#716

Draft
ArdtK wants to merge 16 commits intomasterfrom
chore/702-make-analysis-settings-private
Draft

chore: #710 make analysis settings private#716
ArdtK wants to merge 16 commits intomasterfrom
chore/702-make-analysis-settings-private

Conversation

@ArdtK
Copy link
Contributor

@ArdtK ArdtK commented Sep 25, 2025

Issue addressed

Solves #710

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

Instead of removing AnalysisConfigData.static_path (is required to get origin-destination info), it is made private, along with other properties that should come fromt the NetworkConfigData:

  • root_path
  • network
  • origin_destinations
  • aggregate_wl
    Remove private properties from initialization of AnalysisConfigData in notebooks.

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@ArdtK ArdtK marked this pull request as draft September 26, 2025 05:56
@ArdtK ArdtK changed the base branch from master to chore/702-remove-hazard-name September 26, 2025 06:01
@ArdtK ArdtK changed the base branch from chore/702-remove-hazard-name to master September 26, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant