Skip to content

feat: update AnalysisFactory to map from the new dataclasses#768

Draft
Carsopre wants to merge 37 commits intomasterfrom
feat/739-update-analysisfactory-to-map-from-the-new-dataclasses
Draft

feat: update AnalysisFactory to map from the new dataclasses#768
Carsopre wants to merge 37 commits intomasterfrom
feat/739-update-analysisfactory-to-map-from-the-new-dataclasses

Conversation

@Carsopre
Copy link
Collaborator

@Carsopre Carsopre commented Oct 14, 2025

Issue addressed

Solves #739

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

Explain how you addressed the resolution of the related issue, what choices you made and why.

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

During integration of the new approach I found discrepancies between the former dataclasses and the new ones, in particular:

  • hours_per_traffic_period, is no longer present, I added it where needed (BaseLinkLossesConfigData)..
  • multi_link_isolated (ConfigData), was not mentioned for migration, I had to add it myself ( MultiLIinkIsolatedLocationsConfigData) as a specialization from BaseOriginDestinationConfigData.
  • 'BaseLinkLossesConfigData' object has no field threshold,
    • this has an effect while calculating traffic losses.
    • it can also be seen in MultiLinkRedundancy.execute()
    • This is seen in many of the examples as well.

@Carsopre Carsopre linked an issue Oct 14, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update AnalysisFactory to map from the new dataclasses

1 participant