feat: update AnalysisFactory to map from the new dataclasses#768
Draft
feat: update AnalysisFactory to map from the new dataclasses#768
AnalysisFactory to map from the new dataclasses#768Conversation
…sSectionAdaptation' and its related option; Extended tests
…nOptionConfigData
…d in earlier commits
… 'OptimalRouteOriginDestination'
…m-the-new-dataclasses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue addressed
Solves #739
Code of conduct
What has been done?
Explain how you addressed the resolution of the related issue, what choices you made and why.
Checklist
blackandisortdefinitions.master.Additional Notes (optional)
During integration of the new approach I found discrepancies between the former dataclasses and the new ones, in particular:
hours_per_traffic_period, is no longer present, I added it where needed (BaseLinkLossesConfigData)..multi_link_isolated(ConfigData), was not mentioned for migration, I had to add it myself (MultiLIinkIsolatedLocationsConfigData) as a specialization fromBaseOriginDestinationConfigData.threshold,MultiLinkRedundancy.execute()