Look for source IP in auth #209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symroe
force-pushed
the
allow-list-ips
branch
from
65e0376 to
9733ce4
Compare
symroe
force-pushed
the
allow-list-ips
branch
from
9733ce4 to
7070d96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the SSM parameter to dev and prod accounts.
The dev account contains actual IP addresses and the prod account contains an empty string (it's never going to be used as we don't auth the prod account).
I've also tested that the values in the IP parameter actually work in real conditions, after I did a temp deploy to dev. The site worked as expected for allow list IPs and non-allow list (e.g we get basic auth as expected)