Skip to content

Conversation

FajarKim
Copy link
Contributor

Description

I made a change from "Tidak termasuk {days}" to "Kecuali {days}". This was done because the equivalent of "kecuali" is more precise and clear to express exclusion in Indonesian. The word "tidak termasuk" can cause ambiguity because it literally only states that something is not included, whereas the word "kecuali" explicitly indicates that the days are excluded from the calculation or list. Thus, "Kecuali {days}" is easier to understand and directly conveys the overall intention of exclusion.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

None

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@DenverCoder1 DenverCoder1 merged commit 524dc2c into DenverCoder1:main Mar 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants