Skip to content

ro1.php #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ro1.php #837

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd01e76
ro1.php
CristinaEU1 Oct 1, 2025
7617e4a
Merge branch 'main' into pr/837
DenverCoder1 Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/translations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,15 @@
"Present" => "Presente",
"Excluding {days}" => "Exceto {days}",
],
"ro_cuDiacritice" => [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to call this ro_cuDiacritice instead of ro for simplicity? Would there need to be other versions of Romanian supported separately?

Suggested change
"ro_cuDiacritice" => [
"ro" => [

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CristinaEU1 this is failing the CI test:

Locale 'ro_cuDiacritice' is not normalized. Expected 'ro'.

Copy link
Owner

@DenverCoder1 DenverCoder1 Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, currently the script expects the locale to have a language code (2 to 3 letters), optionally followed by a script code (4 letters), optionally followed by a region code (2 letters or 3 numbers), for example, "ro", "ro_RO", "ro_MD" are options, sometimes we use scripts like "zh_Hans" to differentiate from "zh_Hant", but in general we only specify region and script if it's not the "typical" for this language. We can change the normalization if we need to, but in this case, I think Romanian should just be "ro" because (as far as I know) we won't need to implement a version of Romanian without diacritice.

https://github.com/DenverCoder1/github-readme-streak-stats/blob/main/src%2Fcard.php#L265

"Total Contributions" => "Contribuții totale",
"Current Streak" => "Seria Actuală",
"Longest Streak" => "Cea mai lungă serie",
"Week Streak" => "Seria săptămânală",
"Longest Week Streak" => "Cea mai lungă serie săptămânală",
"Present" => "Prezent",
"Excluding {days}" => "Excluzând {days}",
],
"ru" => [
"Total Contributions" => "Общий вклад",
"Current Streak" => "Текущая серия",
Expand Down
Loading