projects: show ancestor path#5827
Draft
valentijnscholten wants to merge 1 commit intoDependencyTrack:masterfrom
Draft
projects: show ancestor path#5827valentijnscholten wants to merge 1 commit intoDependencyTrack:masterfrom
valentijnscholten wants to merge 1 commit intoDependencyTrack:masterfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When searching for projects/components/vulnerabilities there's no visual indication of where in the Project Hierarchy a project is shown.
Addressed Issue
(partly) fixes #1353, #1362
Additional Details
In v4 we need to do perform some additional java code to get the "ancestor path" populated. But in v5 this will be easier due to the materialized view being used there. Happy to forward port the feature to v5.
I haven't created tests yet as I first would like to get confirmation this is something that can be added to v4. I know v5 is around the corner. At the same it might take some time before v5 is released as GA and everybody has moved over. This PR fixes a real need in v4.
FrontEnd companion PR: TBD
Considerations
Having the full hierarchy view when displaying ony a subset/searchresult of projects is non-trivial to implement if we take features such as paging into account. Maybe for v5 someone has a better proposal, for now an additional column seems helpful in v4.
Checklist