Merged
Conversation
nscuro
force-pushed
the
decomm-notification-publisher
branch
from
642c942 to
289aa62
Compare
This was referenced Jan 26, 2026
nscuro
force-pushed
the
decomm-notification-publisher
branch
from
289aa62 to
6bf8967
Compare
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro
force-pushed
the
decomm-notification-publisher
branch
from
6bf8967 to
b651676
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR decommissions the notification publisher component from the Hyades Helm chart, removing all associated configuration, templates, and helper functions. It also includes a bug fix for the vulnerability analyzer templates and formatting improvements in CI test files.
Changes:
- Removed notification publisher configuration from values.yaml and values.schema.json
- Deleted notification publisher Kubernetes templates (deployment and HPA)
- Removed notification publisher helper template functions
- Fixed incorrect reference to notificationPublisher.initContainers in vulnerability analyzer templates (should reference vulnAnalyzer.initContainers)
- Corrected YAML indentation for ports configuration in CI test files
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/hyades/values.yaml | Removed notificationPublisher configuration section |
| charts/hyades/values.schema.json | Removed notificationPublisher JSON schema definition |
| charts/hyades/templates/vuln-analyzer/statefulset.yaml | Fixed bug: changed notificationPublisher.initContainers to vulnAnalyzer.initContainers |
| charts/hyades/templates/vuln-analyzer/deployment.yaml | Fixed bug: changed notificationPublisher.initContainers to vulnAnalyzer.initContainers |
| charts/hyades/templates/notification-publisher/hpa.yaml | Deleted entire file |
| charts/hyades/templates/notification-publisher/deployment.yaml | Deleted entire file |
| charts/hyades/templates/_helpers.tpl | Removed notification publisher helper template functions |
| charts/hyades/ci/test-vulnanalyzer-statefulset-values.yaml | Fixed ports indentation in redpanda container definition |
| charts/hyades/ci/test-values.yaml | Fixed ports indentation in redpanda container definition |
| charts/hyades/ci/test-initializer-values.yaml | Fixed ports indentation in redpanda container definition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API server PR: DependencyTrack/hyades-apiserver#1624
Hyades PR: DependencyTrack/hyades#1977
Frontend PR: DependencyTrack/hyades-frontend#386