Skip to content

Materialize project hierarchies in separate table#1087

Merged
nscuro merged 1 commit intomainfrom
issue-1699
Mar 24, 2025
Merged

Materialize project hierarchies in separate table#1087
nscuro merged 1 commit intomainfrom
issue-1699

Conversation

@nscuro
Copy link
Member

@nscuro nscuro commented Mar 7, 2025

Description

Materializes project hierarchies in separate table.

Addressed Issue

Closes DependencyTrack/hyades#1699

Additional Details

ADR with more details: https://github.com/DependencyTrack/hyades/blob/issue-1699/docs/architecture/decisions/005-materialize-project-hierarchies.md

Hyades PR: DependencyTrack/hyades#1700

Warning

#1100 should be merged before or shortly after this PR, to ensure that triggers on project deletions fire as expected.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly~
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the enhancement New feature or request label Mar 7, 2025
@nscuro nscuro added this to the 5.6.0 milestone Mar 7, 2025
@codacy-production
Copy link

codacy-production bot commented Mar 7, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c66cf10) 23023 19394 84.24%
Head commit (e593c67) 22978 (-45) 19352 (-42) 84.22% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1087) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro force-pushed the issue-1699 branch 2 times, most recently from 4345a48 to d8f8df7 Compare March 8, 2025 13:11
@nscuro nscuro force-pushed the issue-1699 branch 2 times, most recently from b7e4bca to 6ecb73b Compare March 9, 2025 21:27
@nscuro nscuro marked this pull request as ready for review March 9, 2025 21:28
@nscuro nscuro marked this pull request as draft March 18, 2025 11:26
@nscuro

This comment was marked as outdated.

@nscuro nscuro marked this pull request as ready for review March 18, 2025 19:57
Signed-off-by: nscuro <nscuro@protonmail.com>

# Conflicts:
#	src/main/resources/migration/changelog-v5.6.0.xml
#	src/test/java/org/dependencytrack/resources/v1/ProjectResourceTest.java
Copy link
Collaborator

@sahibamittal sahibamittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@nscuro nscuro merged commit 78404cd into main Mar 24, 2025
9 checks passed
@nscuro nscuro deleted the issue-1699 branch March 24, 2025 15:57
nscuro added a commit to DependencyTrack/hyades that referenced this pull request Apr 23, 2025
It was implemented in DependencyTrack/hyades-apiserver#1087

Signed-off-by: Niklas <nscuro@protonmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Materialize project hierarchies to avoid recursive queries for ACL checks

2 participants