Skip to content

Replace github-api with quarkus-github-api extension#1623

Merged
nscuro merged 1 commit intomainfrom
replace-github-api
Jan 20, 2025
Merged

Replace github-api with quarkus-github-api extension#1623
nscuro merged 1 commit intomainfrom
replace-github-api

Conversation

@nscuro
Copy link
Member

@nscuro nscuro commented Jan 16, 2025

Description

Replaces github-api with quarkus-github-api extension.

The Quarkus extension wraps the library, and takes care of making it compatible with native image.

Native image builds started failing with #1515

Addressed Issue

Closes #1515

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the dependencies Pull requests that update a dependency file label Jan 16, 2025
@nscuro nscuro added this to the 0.6.0 milestone Jan 16, 2025
@codacy-production
Copy link

codacy-production bot commented Jan 16, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+18.34% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (afd76ac) 201 132 65.67%
Head commit (d1ac40d) 6899 (+6698) 5796 (+5664) 84.01% (+18.34%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1623) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

The Quarkus extension wraps the library, and takes care of making it compatible with native image.

Native image builds started failing with #1515

Signed-off-by: nscuro <nscuro@protonmail.com>

# Conflicts:
#	pom.xml
@nscuro nscuro force-pushed the replace-github-api branch from 591327e to d1ac40d Compare January 20, 2025 10:18
@nscuro nscuro merged commit 09c253b into main Jan 20, 2025
13 checks passed
@nscuro nscuro deleted the replace-github-api branch January 20, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants