Draft
Conversation
kirill-stupakov
requested changes
Nov 24, 2023
web-app/client/src/components/AlgorithmFormConfigurator/AlgorithmFormConfigurator.tsx
Outdated
Show resolved
Hide resolved
web-app/client/src/components/AlgorithmFormConfigurator/useFormFactory.tsx
Outdated
Show resolved
Hide resolved
web-app/client/src/components/Inputs/NumberSlider/NumberSlider.tsx
Outdated
Show resolved
Hide resolved
kirill-stupakov
requested changes
Dec 7, 2023
Collaborator
There was a problem hiding this comment.
И плюс всё то, что я не зарезолвил с прошлого ревью
UPD: а ещё в папочке каждого компонента должен быть файл index.ts, который делает реэкспорт того, что твой компонент отдаёт во внешку
А импорт компонента тогда будет выглядеть так:
- import Component from '@components/Component/Component`;
+ import Component from '@components/Component';
web-app/client/src/components/AlgorithmFormConfigurator/AlgorithmFormConfigurator.tsx
Outdated
Show resolved
Hide resolved
web-app/client/src/components/AlgorithmFormConfigurator/ConfigureAlgorithm.module.scss
Outdated
Show resolved
Hide resolved
kirill-stupakov
requested review from
Pechenux
and removed request for
Pechenux
Pechenux
requested changes
Dec 8, 2023
web-app/client/src/components/AlgorithmFormConfigurator/AlgorithmFormConfigurator.tsx
Outdated
Show resolved
Hide resolved
web-app/client/src/components/AlgorithmFormConfigurator/AlgorithmFormConfigurator.tsx
Outdated
Show resolved
Hide resolved
web-app/client/src/constants/configuratorForm/ACForm/SeedCustomInputs/index.ts
Outdated
Show resolved
Hide resolved
web-app/client/src/components/AlgorithmFormConfigurator/AlgorithmFormConfigurator.tsx
Outdated
Show resolved
Hide resolved
kirill-stupakov
requested changes
Dec 10, 2023
web-app/client/src/components/CollapsableView/CollapsableView.tsx
Outdated
Show resolved
Hide resolved
web-app/client/src/components/AlgorithmFormConfigurator/AlgorithmFormConfigurator.tsx
Outdated
Show resolved
Hide resolved
Collaborator
|
плюс с предыдущих ревью не всё зарезолвлено |
kirill-stupakov
requested changes
Dec 12, 2023
Collaborator
kirill-stupakov
left a comment
kirill-stupakov
left a comment
There was a problem hiding this comment.
Ждём description, и потом тыкаю апрув
Collaborator
|
Надо мёрж-коммит заменить на ребейз |
kirill-stupakov
approved these changes
Jan 5, 2024
Collaborator
|
ПР пока не мёржим, т.к. нет бэка |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.