Retoma pendências da Issue 103 sobre atribuição de valores específicos#186
Merged
leonelsanchesdasilva merged 16 commits intoprincipalfrom Apr 26, 2025
Merged
Retoma pendências da Issue 103 sobre atribuição de valores específicos#186leonelsanchesdasilva merged 16 commits intoprincipalfrom
leonelsanchesdasilva merged 16 commits intoprincipalfrom
Conversation
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success201 tests passing in 25 suites. Report generated by 🧪jest coverage report action from 87d407a |
…arados por vírgula
leonelsanchesdasilva
approved these changes
Apr 26, 2025
Contributor
leonelsanchesdasilva
left a comment
leonelsanchesdasilva
left a comment
There was a problem hiding this comment.
Meus comentários não bloqueiam o merge. Devem ser usados para ajustes futuros.
| valoresAceitos: { [valorFoles: string]: string } = { | ||
| auto: "auto", | ||
| nenhum: "none", | ||
| pinturaVisivel: "visiblePainted", |
Contributor
There was a problem hiding this comment.
Estou pensando em não mimetizar esse padrão camelCase mais futuramente. Me parece que foi algo definido apressadamente no próprio padrão do CSS, mas não é algo que pretendo manter em FolEs. Por ora, deixamos assim.
| } | ||
| }); | ||
| return `${" ".repeat(indentacao)}${modificador.propriedadeCss}: ${unirValores};\n`; | ||
| } else { |
Contributor
There was a problem hiding this comment.
Via de regra: quando há else { return ... }, você não precisa do else: apenas do return. Usamos else { return ... } quando não há uma forma de quebrar o fluxo de execução do código.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.