dev: update handling of dev and beta modes#1400
Merged
Conversation
DayKev
added
Refactor
DayKev
force-pushed
the
dev/is_dev-and-start-commands
branch
from
444b4c8 to
6698e3e
Compare
- Replace the `start` command in `package.json` with `start:prod` and `start:beta`, which run the game in "production" and "beta" mode respectively Previously, `start` would run the game in "development" mode just like `start:dev` due to the `vite` command running in "development" mode by default if no `--mode` arg was passed - Add `IS_DEV` global constant that checks for "development" mode - Remove `Api#isLocal` and replace its uses with `BYPASS_LOGIN` - Add " (Beta)" to window title and game version displayed on the title screen when in "development" or "beta" mode - Replace `.then()` pattern with `await` in `main.ts` - Remove obsolete commented code in `game-data.ts`
DayKev
force-pushed
the
dev/is_dev-and-start-commands
branch
from
6698e3e to
559192e
Compare
flx-sta
approved these changes
Feb 14, 2026
Contributor
flx-sta
left a comment
flx-sta
left a comment
There was a problem hiding this comment.
LGTM.
A bit polluted with style fixes but easy
| "version": "0.1.0", | ||
| "type": "module", | ||
| "scripts": { | ||
| "start": "vite", |
Contributor
There was a problem hiding this comment.
Maybe we should add a start that give you a selection of which mode you wanna launch via prompter.
Contributor
Author
There was a problem hiding this comment.
I don't think we need an extra layer of indirection for something so simple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
The title of the webpage and the version string displayed on the title screen will have " (Beta)" appended to them when running in "beta" (e.g. some sort of beta website) or "development" mode (e.g. locally).
Why am I making these changes?
General code simplification and cleanup.
What are the changes from a developer perspective?
Replaced the
startcommand inpackage.jsonwithstart:prodandstart:beta, which run the game in "production" and "beta" mode respectively.Previously,
startwould run the game in "development" mode just likestart:devdue to thevitecommand running in "development" mode by default if no--modearg is passed.Added
IS_DEVglobal constant that checks for "development" mode.Removed
Api#isLocaland replace its uses withBYPASS_LOGIN.Added " (Beta)" to window title and game version displayed on the title screen when in "development" or "beta" mode.
Replaced
.then()pattern withawaitinmain.ts.Removed obsolete commented code in
game-data.ts.Added return types to api methods.
Updated
deploy-beta.ymlworkflow to use "beta" mode when building (though the workflow is currently disabled anyway).Checklist
betaas my base branch