[Output Saver] Initial extension of outputsaver for SVG#136
Open
oloapinivad wants to merge 6 commits intomainfrom
Open
[Output Saver] Initial extension of outputsaver for SVG#136oloapinivad wants to merge 6 commits intomainfrom
oloapinivad wants to merge 6 commits intomainfrom
Conversation
5 tasks
…metadata function. Add a centralised add_figure_metadata tha add metadata by format extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
This will implement the support for SVG figure output.
I started very simply, noticed a couple of issues
add_pdf_metadataandadd_png_metadataare still part of AQUA core, and should be transferred here I guesssave_${extension}flag. I would possibly refactor itIssues closed by this pull request:
Close #135
People involved:
Please leave the checkboxes that apply to this pull request.
If you find a missing checkbox, please add it to the list.
Make sure to complete the checkboxes before applying the "ready to merge" label.
Please apply the "run tests" label if you want to trigger CI tests.