You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please leave the checkboxes that apply to this pull request.
If you find a missing checkbox, please add it to the list.
Make sure to complete the checkboxes before applying the "ready to merge" label.
Please apply the "run tests" label if you want to trigger CI tests.
@oloapinivad so far I implemented also the changes regarding #159, but actually the error regarding so and thetao was not occurring in v0.19-operational branch.
What's your opinion? Should we only keep the correct time selection change or both changes implemented here are fine to keep? On this branch in any case the diagnostic runs and successfully generates the plots.
Anyway, I devoted my LUMI for v0-19-operational AQUA analysis runs, and this is behaving exactly as expected: before this PR, the same issue experienced in #168 occurred for current main has occurred in v0.19-operational as well. With this branch, the issue is solved
self = <test_console.TestAquaConsole object at 0x7fbe40c3b200>
delete_home = <function delete_home.<locals>._modify_home at 0x7fbe1bbec680>
run_aqua = <function run_aqua.<locals>._run_aqua_console at 0x7fbe24720f40>
tmpdir = PosixPath('.../pytest-of-root/pytest-0/tmp0')
run_aqua_console_with_input = <function run_aqua_console_with_input.<locals>._run_aqua_console at 0x7fbe24720540>
def test_console_without_home(self, delete_home, run_aqua, tmpdir, run_aqua_console_with_input):
# getting fixture
delete_home()
mydir = str(tmpdir)
print(f"HOME is set to: {os.environ.get('HOME')}")
# check unexesting installation
with pytest.raises(SystemExit) as excinfo:
run_aqua(['install', MACHINE])
assert excinfo.value.code == 1
# install from path without home
shutil.rmtree(os.path.join(mydir, 'vicesindaco'))
run_aqua_console_with_input(['-v', 'install', MACHINE, '-p', os.path.join(mydir, 'vicesindaco')], 'yes')
assert os.path.isdir(os.path.join(mydir, 'vicesindaco'))
assert os.path.isfile(os.path.join(mydir, 'vicesindaco', 'config-aqua.yaml'))
> assert not os.path.exists(os.path.join(mydir, '.aqua'))
E AssertionError: assert not True
E + where True = <function exists at 0x7fbe7af63380>('.../pytest-of-root/pytest-0/tmp0/.aqua')
E + where <function exists at 0x7fbe7af63380> = <module 'posixpath' (frozen)>.exists
E + where <module 'posixpath' (frozen)> = os.path
E + and '.../pytest-of-root/pytest-0/tmp0/.aqua' = <function join at 0x7fbe7ad24900>('.../pytest-of-root/pytest-0/tmp0', '.aqua')
E + where <function join at 0x7fbe7ad24900> = <module 'posixpath' (frozen)>.join
E + where <module 'posixpath' (frozen)> = os.path
tests/test_console.py:587: AssertionError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
Porting of AQUA-diagnostics PR #178
Please leave the checkboxes that apply to this pull request.
If you find a missing checkbox, please add it to the list.
Make sure to complete the checkboxes before applying the "ready to merge" label.
Please apply the "run tests" label if you want to trigger CI tests.