Skip to content

Improve IDB testing / mitigation#9747

Merged
bhollis merged 5 commits intomasterfrom
storage-test-get
Aug 22, 2023
Merged

Improve IDB testing / mitigation#9747
bhollis merged 5 commits intomasterfrom
storage-test-get

Conversation

@bhollis
Copy link
Contributor

@bhollis bhollis commented Aug 22, 2023

May fix #9716.

This:

  • Backports the fix from Improve error handling jakearchibald/idb-keyval#164 so we hopefully get a better error than null.
  • Adds a get test to the StorageTest.
  • Adds a second layer of "don't crash" to the places where we rely on IDB get.
  • Restores the delete-database hack to StorageTest. My new hypothesis is that that was working, but we were filtering out the exception reporting to Sentry. I've removed our ignored errors list to make sure they get through (though I'll probably have to add some back in, I don't know what they were all for).

@bhollis bhollis requested a review from robojumper August 22, 2023 19:54
Co-authored-by: robojumper <robojumper@gmail.com>
@bhollis bhollis merged commit fae2a39 into master Aug 22, 2023
@bhollis bhollis deleted the storage-test-get branch August 22, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error Null

2 participants