might fix steam socket issue #342
Conversation
| pInfo->m_hListenSocket = connect_socket->second.listen_socket_id; | ||
| if (connect_socket->second.real_port != SNS_DISABLED_PORT) { | ||
| pInfo->m_unIPRemote = network->getIP(connect_socket->second.remote_identity.GetSteamID()); | ||
| pInfo->m_unPortRemote = connect_socket->first; |
There was a problem hiding this comment.
Won't that be the key of the dictionary? HSteamNetConnection (some random number)
Should it be connect_socket->second.real_port ?
This seems to be a bug in the original function as well (see above)
Steam_Networking_Sockets::set_steamnetconnectioninfo(...) {
...
pInfo->m_addrRemote.SetIPv4(network->getIP(..., connect_socket->first);
...
}The 2nd arg should be the port I assume.
otavepto
left a comment
otavepto
left a comment
There was a problem hiding this comment.
The arg for the real port might not be correct
|
There seem to be more instances where the random dictionary key is used inappropriately, but none are related to this PR, for example: bool Steam_Networking_Sockets::send_packet_new_connection(HSteamNetConnection m_hConn)
{
...
msg.mutable_networking_sockets()->set_connection_id_from(connect_socket->first);
...Here I would assume |
|
fucking cpp cant even understand anything here |
|
Yeah I get that feeling too every time man 😆 |
No description provided.