Fix playtime tick not being always called#349
Merged
Detanup01 merged 2 commits intoDetanup01:devfrom Sep 12, 2025
Merged
Conversation
Contributor
Author
|
Fixed another bug in the load function, the isdigit check in the if statement was giving problems in case of null terminators. The try catch still catches eventual errors while parsing the number |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in some games the tick function of the playtime counter doesn't always get called, moving the function outside of the if statement resolved the issue while still making the function call happen once every 300ms
A game that had that problem was Hollow Knight