Skip to content

Conversation

@wunnr
Copy link
Contributor

@wunnr wunnr commented Oct 31, 2025

Much like the existing env var "GseAppPath" that overrides the emu's program path. This new env var may make it easier for programs like Nucleus Coop or my own PartyDeck that launch multiple instances of games at a time with goldberg. The check for the env var seemed most appropriate in Local_Storage::get_user_appdata_path(), but you can let me know if it would be better off as part of a different function.

Copy link
Collaborator

@universal963 universal963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is an appropriate location, since by judging the function name it should be used only to retrieve %appdata% directory. What about this function when parsing local_save:

// user::saves::local_save_path
static bool parse_local_save(std::string &save_path)
{
auto ptr = ini.GetValue("user::saves", "local_save_path");
if (!ptr || !ptr[0]) return false;
save_path = common_helpers::to_absolute(common_helpers::string_strip(ptr), Local_Storage::get_program_path());
if (save_path.size() && save_path.back() != *PATH_SEPARATOR) {
save_path.push_back(*PATH_SEPARATOR);
}
PRINT_DEBUG("using local save path '%s'", save_path.c_str());
return true;
}

@wunnr
Copy link
Contributor Author

wunnr commented Nov 4, 2025

Moved to parse_local_save as requested

@Detanup01 Detanup01 merged commit b6acafd into Detanup01:dev Nov 5, 2025
64 checks passed
@wunnr wunnr deleted the env_save_path branch November 5, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants