Provide default value for custom settings #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh ouch. Thanks. Can we add an evaluating check to this to make sure we don't break their configs again? |
Member
Author
|
@grahamc What do you mean by an evaluating check? Like an assertion? |
Member
|
Probably means something in CI here that prevents the PR from being merged if we regress this. |
Member
Author
|
I'm not sure there's a great way to do that without adding a nix-darwin dependency |
Member
|
We actually already do this exact test, we just need to include our module 🙈 -- can you please integrate https://github.com/DeterminateSystems/determinate/pull/123/files into your branch? |
Member
Author
|
@grahamc Makes sense! I did that and also added a check that ensures that passing actual custom settings evaluates properly. |
cole-h
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this default, evaluating a nix-darwin config that uses this module fails if
determinate-nix.customSettingsis unspecified. As we can reasonably expect many people to not use this, we should set a default of{}, which the module handles by not writing anynix.custom.conf.