Skip to content

Conversation

@cole-h
Copy link
Member

@cole-h cole-h commented Mar 26, 2025

Description
Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

success:
runs-on: ubuntu-latest
needs: run-systems
if: always()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want it to not run when the job was cancelled, we might want ...

Suggested change
if: always()
if: success() || failure()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to think about how that would interact; it's safer to just say "always run this", since we'll only exit with a failure if the following if condition is satisfied.

@cole-h cole-h added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 0570f8e Mar 26, 2025
5 checks passed
@cole-h cole-h deleted the cole-h-patch-1 branch March 26, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants