superficial rebrand from magic-nix-cache-action to flakehub-cache-action #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemickens
force-pushed
the
colemickens/fhca
branch
11 times, most recently
from
1187063 to
378c6fe
Compare
Member
|
@colemickens I'm still seeing a fair number of references to MNC, for example in |
colemickens
force-pushed
the
colemickens/fhca
branch
from
378c6fe to
1011fcf
Compare
Member
Author
|
Thanks @lucperkins, definitely patched up a few more. The remaining ones, I think, are "correct" references to |
cole-h
reviewed
Jan 17, 2025
cole-h
reviewed
Jan 17, 2025
README.md
Outdated
| | `source-revision` | The revision of `nix-magic-nix-cache` to use. Conflicts with all other `source-*` options. | | | | ||
| | `source-tag` | The tag of `magic-nix-cache` to use. Conflicts with all other `source-*` options. | | | | ||
| | `source-url` | A URL pointing to a `magic-nix-cache` binary. Overrides all other `source-*` options. | | | | ||
| | `startup-notification-port` | The port magic-nix-cache uses for daemon startup notification. | | 41239 | |
Member
There was a problem hiding this comment.
nit:
Suggested change
| | `startup-notification-port` | The port magic-nix-cache uses for daemon startup notification. | | 41239 | | |
| | `startup-notification-port` | The port `magic-nix-cache` uses for daemon startup notification. | | 41239 | |
cole-h
reviewed
Jan 17, 2025
| > This means the cache is only usable in CI. | ||
| > [Zero to Nix][z2n] has an article on binary caching if you want to [share Nix builds][z2ncache] with users outside of CI. | ||
| - Automatic, authenticated integration with GitHub Actions | ||
| - Cached paths are available on developer and target machines |
Member
There was a problem hiding this comment.
what does "target machines" mean? maybe something like this is better:
Suggested change
| - Cached paths are available on developer and target machines | |
| - Cached paths are available wherever you are logged in to FlakeHub, including on developer machines |
Co-authored-by: Cole Helbling <[email protected]>
colemickens
force-pushed
the
colemickens/fhca
branch
from
1f2cdbe to
766373a
Compare
grahamc
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The README needs more attention, but I wanted to get this pushed up to try and test E2E with it, as it is.
Checklist