[FH-807] ci: fixup fhc disable test grep #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
:/ Is there a reason we don't run the matrix on PRs... ? It would be nice to validate this without manually having to emulate this matrix locally. cc: @grahamc ? |
Member
|
@colemickens They run when we click "merge when ready" -- does that work? |
grahamc
approved these changes
May 14, 2025
Member
Author
|
I assume you mean it runs as part of the merge_queue? I guess I'm confused how the breaking change merge in then... ? (unless the matrix tests with the "live" action rather than the one from the current PR?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes FH-807
Checklist