Update detsys-ts: Merge pull request #109 from DeterminateSystems/tsup-to-tsdown#148
Conversation
…om DeterminateSystems/tsup-to-tsdown` (`285768c0d657f9709cb689893f12895c36923093`)
WalkthroughUpdated the devDependency @types/node in package.json from ^20.19.12 to ^20.19.13. No other changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
32-32: Lockfile already pins detsys-ts to commit 285768c0d657f9709cb689893f12895c36923093 — package.json pinning optionalpnpm-lock.yaml resolves detsys-ts to github.com/DeterminateSystems/detsys-ts/285768c0d657f9709cb689893f12895c36923093, so installs are deterministic when the lockfile is used. If you want the commit visible in package.json, apply:
- "detsys-ts": "github:DeterminateSystems/detsys-ts", + "detsys-ts": "github:DeterminateSystems/detsys-ts#285768c0d657f9709cb689893f12895c36923093",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
dist/index.jsis excluded by!**/dist/**pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build
🔇 Additional comments (1)
package.json (1)
38-38: Approve: @types/node bumped to v20 — Action runtime is Node 20Dev-only bump is fine: package.json devDependency is ^20.19.13 and action.yml declares using: "node20".
Bump
detsys-tsto the latestHEADand regenerate application bundle.285768c0d657f9709cb689893f12895c36923093DeterminateSystems/detsys-ts#109c7303495f43d348cac78091ef434443b1ef22485..285768c0d657f9709cb689893f12895c36923093109.diffSummary by CodeRabbit