Skip to content

Update detsys-ts: Merge pull request #109 from DeterminateSystems/tsup-to-tsdown#148

Merged
lucperkins merged 1 commit intoDeterminateSystems:mainfrom
detsys-pr-bot:detsys-ts-update-285768c0d657f9709cb689893f12895c36923093
Sep 12, 2025
Merged

Update detsys-ts: Merge pull request #109 from DeterminateSystems/tsup-to-tsdown#148
lucperkins merged 1 commit intoDeterminateSystems:mainfrom
detsys-pr-bot:detsys-ts-update-285768c0d657f9709cb689893f12895c36923093

Conversation

@detsys-pr-bot
Copy link
Contributor

@detsys-pr-bot detsys-pr-bot commented Sep 12, 2025

Bump detsys-ts to the latest HEAD and regenerate application bundle.

Summary by CodeRabbit

  • Chores
    • Updated a development dependency to the latest patch release to keep tooling current and ensure better compatibility with the current Node.js type ecosystem.
    • This maintenance update affects only the development environment and has no impact on runtime behavior or user-facing features.
    • Improves reliability of type checking during development, supporting smoother builds and editor integrations without altering application functionality.

…om DeterminateSystems/tsup-to-tsdown` (`285768c0d657f9709cb689893f12895c36923093`)
@coderabbitai
Copy link

coderabbitai bot commented Sep 12, 2025

Walkthrough

Updated the devDependency @types/node in package.json from ^20.19.12 to ^20.19.13. No other changes.

Changes

Cohort / File(s) Change summary
Dependency version bump
package.json
Bump @types/node devDependency from ^20.19.12 to ^20.19.13.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • grahamc

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title identifies the primary change—updating detsys-ts—which matches the changeset, so it is related to the PR; however it contains noisy merge metadata and the source branch/PR reference that make it verbose and less concise than ideal.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

Patch hop, tiny bump—what cheer!
A nibble of types, a version near.
Ears perked high, I sign the log,
One more carrot in the changelog.
Thump-thump—ship it, dear!

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

32-32: Lockfile already pins detsys-ts to commit 285768c0d657f9709cb689893f12895c36923093 — package.json pinning optional

pnpm-lock.yaml resolves detsys-ts to github.com/DeterminateSystems/detsys-ts/285768c0d657f9709cb689893f12895c36923093, so installs are deterministic when the lockfile is used. If you want the commit visible in package.json, apply:

-    "detsys-ts": "github:DeterminateSystems/detsys-ts",
+    "detsys-ts": "github:DeterminateSystems/detsys-ts#285768c0d657f9709cb689893f12895c36923093",
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1177eb6 and 2ed7ab5.

⛔ Files ignored due to path filters (2)
  • dist/index.js is excluded by !**/dist/**
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build
🔇 Additional comments (1)
package.json (1)

38-38: Approve: @types/node bumped to v20 — Action runtime is Node 20

Dev-only bump is fine: package.json devDependency is ^20.19.13 and action.yml declares using: "node20".

@lucperkins lucperkins added this pull request to the merge queue Sep 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2025
@lucperkins lucperkins added this pull request to the merge queue Sep 12, 2025
Merged via the queue into DeterminateSystems:main with commit 9934a5f Sep 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants