Add option for disabling closure computation in GHA cache#112
Open
yfyf wants to merge 1 commit intoDeterminateSystems:mainfrom
Open
Add option for disabling closure computation in GHA cache#112yfyf wants to merge 1 commit intoDeterminateSystems:mainfrom
yfyf wants to merge 1 commit intoDeterminateSystems:mainfrom
Conversation
Allows to only cache the built derivations without their closures. This avoids polluting the GHA cache with many duplicate entries, which happens when a downstream derivation changes (and is rebuilt), but its dependencies don't (but would get pushed to the cache each time regardless).
Author
|
Amended the commit after |
|
What is holding this PR up? This is a pretty significant fix, willing to help. |
|
Bump, this is a significant fix (if it works) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to only cache the built derivations without their closures.
This avoids polluting the GHA cache with many duplicate entries, which happens when a downstream derivation changes (and is rebuilt), but its dependencies don't (but would get pushed to the cache each time regardless).
Should reduce the impact of issues like #75.
Not sure how to test this properly, but verified manually that
OUT_PATHS=$(which bash) ./target/debug/magic-nix-cache --no-closureenqueues only the bash NAR.