Skip to content

feat: skip small files (<5KB) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hraban wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: skip small files (<5KB) #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13a8c20
feat: skip small files (<5KB)
hraban May 22, 2024
a52f3b7
docs: explain why filter small files
hraban May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions magic-nix-cache/src/gha.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,18 @@ async fn upload_path(
// Upload the NAR.
let nar_path = format!("{}.nar.zstd", path_info.nar_hash.to_base32());

// This limit was chosen arbitrarily, to reduce the chances of hitting GHA
// cache API limits. An even better filter would be “cost of rebuilding
// this derivation”, but that metric is not readily available.
if path_info.nar_size < 5000 {
tracing::debug!(
"Skipping small file '{}' ({}b)",
nar_path,
path_info.nar_size
);
return Ok(());
}

let nar_allocation = api.allocate_file_with_random_suffix(&nar_path).await?;

let nar_stream = store.nar_from_path(path.clone());
Expand Down