Annotate hash mismatches when Determinate features are enabled#158
Merged
Annotate hash mismatches when Determinate features are enabled#158
Conversation
grahamc
reviewed
Apr 14, 2025
src/fixHashes.ts
Outdated
Comment on lines
+25
to
+29
| const output = await getExecOutput("determinate-nixd", [ | ||
| "fix", | ||
| "hashes", | ||
| "--json", | ||
| ]); |
Member
There was a problem hiding this comment.
Suggested change
| const output = await getExecOutput("determinate-nixd", [ | |
| "fix", | |
| "hashes", | |
| "--json", | |
| ]); | |
| const output = await getExecOutput("determinate-nixd", [ | |
| "fix", | |
| "hashes", | |
| "--json", | |
| ], { | |
| silent: true, | |
| }); |
without silent: true the log gets littered with ugly output:
grahamc
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When Determinate features are enabled, this PR adds GitHub Actions annotations to point users directly to hash mismatches in their source files.
Example:
Checklist