Update detsys-ts: Capture the version of Nix in addition to the nix store version (#108)#197
Conversation
…e nix store version (DeterminateSystems#108)` (`c7303495f43d348cac78091ef434443b1ef22485`)
WalkthroughBumps versions of dev dependencies in package.json: got, @types/node, eslint-plugin-prettier, and typescript. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
33-35: Skip Action runtime verification; optionally declare Node engines
There’s noaction.ymlin this repo—this isn’t a JavaScript GitHub Action and CI uses Nix shells for Node. You can optionally add topackage.jsonto document that you need a modern Node for got v14:"type": "module", + "engines": { + "node": ">=20.0.0" + },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
dist/index.jsis excluded by!**/dist/**pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Test: macos-14-large with determinate
- GitHub Check: Test: macos-14-large
- GitHub Check: Test: macos-14-xlarge
- GitHub Check: Test: namespace-profile-default-arm64 with determinate
- GitHub Check: Test: namespace-profile-default-arm64
- GitHub Check: Test: macos-14-xlarge with determinate
- GitHub Check: Test: ubuntu-latest
- GitHub Check: Test: macos-13-large
- GitHub Check: Test: nscloud-ubuntu-22.04-amd64-4x16
- GitHub Check: Test: macos-13-large with determinate
- GitHub Check: Check the dist/ folder is up to date
🔇 Additional comments (3)
package.json (3)
39-41: @types/node bump looks fine.Matches Node 20+ usage typical for Actions; no concerns.
50-51: No action required: @typescript-eslint/eslint-plugin@7.18.0 is compatible with TS 5.9
Peer dependencies for@typescript-eslint/eslint-plugin@7.18.0listtypescript: "*", and the lockfile shows both the plugin and its parser resolving against TypeScript 5.9.2, confirming compatibility.
47-48: Peer compatibility verified — no changes required. eslint@^8.57.1 meets “>=8.0.0,” prettier@^3.6.2 meets “>=3.0.0,” and eslint-config-prettier@10.1.8 falls within “>=10.1.0” peer range.
| "detsys-ts": "github:DeterminateSystems/detsys-ts", | ||
| "got": "^14.4.7", | ||
| "got": "^14.4.8", | ||
| "string-argv": "^0.3.2", | ||
| "vitest": "^3.2.4" | ||
| }, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Pin detsys-ts commit and move vitest to devDeps for reproducibility and lean installs.
Lockfile likely pins the commit, but encoding the SHA in package.json avoids drift if the lock is regenerated. Vitest shouldn’t be a runtime dep for a bundled Action.
Apply:
"dependencies": {
"@actions/core": "^1.11.1",
"@actions/exec": "^1.1.1",
"@actions/github": "^6.0.1",
- "detsys-ts": "github:DeterminateSystems/detsys-ts",
+ "detsys-ts": "github:DeterminateSystems/detsys-ts#c7303495f43d348cac78091ef434443b1ef22485",
"got": "^14.4.8",
"string-argv": "^0.3.2",
- "vitest": "^3.2.4"
+ "vitest": "^3.2.4"
},
"devDependencies": {
+ "vitest": "^3.2.4",Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In package.json around lines 32 to 36, pin the detsys-ts dependency to a
specific commit SHA (replace "github:DeterminateSystems/detsys-ts" with
"github:DeterminateSystems/detsys-ts#<commit-sha>") to avoid drift when
lockfiles are regenerated, and move "vitest" from dependencies into
devDependencies (remove it from the "dependencies" block and add it under
"devDependencies") so vitest is not installed at runtime for the bundled Action;
update package.json accordingly and run npm install to refresh the lockfile.
2 participants
Bump
detsys-tsto the latestHEADand regenerate application bundle.c7303495f43d348cac78091ef434443b1ef22485DeterminateSystems/detsys-ts#108e439a01995ac029e7481a75c4661a7f60eeb8b19..c7303495f43d348cac78091ef434443b1ef22485108.diffSummary by CodeRabbit