-
Notifications
You must be signed in to change notification settings - Fork 26
Update detsys-ts: nix store trust: accept Determinate Nix 3.15 and newer, which uses a bool instead of int (#127)
#218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… and newer, which uses a bool instead of int (DeterminateSystems#127)` (`4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9`)
📝 WalkthroughWalkthroughThis PR updates three dependency versions in package.json: got from ^14.6.5 to ^14.6.6, Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom Pre-merge Checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @package.json:
- Line 32: The package dependency for detsys-ts is not pinned to the required
commit, so update the "detsys-ts" entry in package.json to reference the
specific commit hash 4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9 (i.e. change
"detsys-ts": "github:DeterminateSystems/detsys-ts" to include
"#4b33fd06d2...02a9") so the detsys-ts#127 fix is pulled into this PR; commit
the updated package.json and run any lockfile/install steps to ensure the new
ref is applied.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
dist/index.jsis excluded by!**/dist/**pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Test: macos-14-large
- GitHub Check: Test: macos-14-xlarge
- GitHub Check: Test: macos-14-large with determinate
- GitHub Check: Test: ubuntu-latest
- GitHub Check: Test: macos-14-xlarge with determinate
- GitHub Check: Test: nscloud-ubuntu-22.04-amd64-4x16
- GitHub Check: Test: namespace-profile-default-arm64 with determinate
- GitHub Check: Test: namespace-profile-default-arm64
- GitHub Check: Check the dist/ folder is up to date
🔇 Additional comments (1)
package.json (1)
33-33: Package versions are valid and secure.All three updated packages exist in the npm registry, are not deprecated, and have no known security vulnerabilities. The versions are appropriate for this update.
| "@actions/core": "^1.11.1", | ||
| "@actions/exec": "^1.1.1", | ||
| "@actions/github": "^6.0.1", | ||
| "detsys-ts": "github:DeterminateSystems/detsys-ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: The detsys-ts dependency is not being updated despite PR objectives.
The PR title and description explicitly state that this PR should update detsys-ts to commit 4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9 to handle the nix store trust boolean/integer change for Determinate Nix 3.15+. However, the detsys-ts dependency specification on this line is unchanged and doesn't pin to the required commit.
To properly implement the PR's stated objective, this line should be updated to:
"detsys-ts": "github:DeterminateSystems/detsys-ts#4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9",Without this change, the nix store trust fix from detsys-ts#127 will not be included in this action.
🤖 Prompt for AI Agents
In @package.json at line 32, The package dependency for detsys-ts is not pinned
to the required commit, so update the "detsys-ts" entry in package.json to
reference the specific commit hash 4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9
(i.e. change "detsys-ts": "github:DeterminateSystems/detsys-ts" to include
"#4b33fd06d2...02a9") so the detsys-ts#127 fix is pulled into this PR; commit
the updated package.json and run any lockfile/install steps to ensure the new
ref is applied.
Bump
detsys-tsto the latestHEADand regenerate application bundle.4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9DeterminateSystems/detsys-ts#127f335f0d0939f2b8488174d3cd5f818d1cec23ab6..4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9127.diffSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.