Skip to content

Comments

Tidy up the macos runner list#224

Merged
grahamc merged 2 commits intomainfrom
push-rwynlvtkrmro
Jan 28, 2026
Merged

Tidy up the macos runner list#224
grahamc merged 2 commits intomainfrom
push-rwynlvtkrmro

Conversation

@grahamc
Copy link
Member

@grahamc grahamc commented Jan 28, 2026

Description
Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

Summary by CodeRabbit

  • Chores
    • Updated CI/CD infrastructure by replacing specific macOS runner versions with the latest ARM64 variant, streamlining the build matrix configuration.
    • Simplified workflow execution logic to ensure consistent step execution across all test runners.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Removed specific macOS runners (macos-13-large, macos-14-large, macos-14-xlarge) from the CI matrix and replaced them with macos-latest (arm64). Simplified the conditional logic by removing the guard clause that excluded certain macOS runners from the "Render the devshell" step, allowing it to run unconditionally on all matrix runners.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
\.github/workflows/ci\.yml
Updated macOS runner selection in install-nix matrix; removed conditional exclusion of specific macOS runners from devshell rendering step, now runs unconditionally across all matrix targets.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Drop x86_64-darwin #207: Modifies the same .github/workflows/ci.yml file's macOS runner matrix and devshell step conditional handling, managing guards for specific macOS runners.

Suggested reviewers

  • colemickels
  • cole-h

Poem

🐰 macOS runners hopped away,
Arm64 takes the stage today,
Conditionals removed with glee,
The devshell runs wild and free!
Simplicity's the rabbit's way! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Tidy up the macos runner list' directly and clearly describes the main change: simplifying and reorganizing the macOS runners configuration in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@grahamc grahamc enabled auto-merge (squash) January 28, 2026 17:13
@grahamc grahamc merged commit c39689c into main Jan 28, 2026
13 checks passed
@grahamc grahamc deleted the push-rwynlvtkrmro branch January 28, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants