Skip to content

ci: always validate that Release checks were successful#1409

Merged
cole-h merged 2 commits intomainfrom
fixup-release-checks-ci
Feb 5, 2025
Merged

ci: always validate that Release checks were successful#1409
cole-h merged 2 commits intomainfrom
fixup-release-checks-ci

Conversation

@cole-h
Copy link
Member

@cole-h cole-h commented Feb 5, 2025

When "needs" jobs fail, they'll make any jobs that depend on them be "skipped". "Skipped" jobs count as a success for the purposes of required checks. We always want this final step to run, even if the "needs" jobs failed (so that this "omnibus" check will halt merging if the "needs" jobs fail).

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

When "needs" jobs fail, they'll make any jobs that depend on them
be "skipped". "Skipped" jobs count as a success for the purposes of
required checks. We always want this final step to run, even if the
"needs" jobs failed (so that this "omnibus" check will halt merging if
the "needs" jobs fail).
@cole-h cole-h enabled auto-merge (squash) February 5, 2025 17:28
@cole-h cole-h mentioned this pull request Feb 5, 2025
6 tasks
@cole-h cole-h merged commit a4e054c into main Feb 5, 2025
22 checks passed
@cole-h cole-h deleted the fixup-release-checks-ci branch February 5, 2025 18:07
@cole-h cole-h added this to the 0.35.0 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants