Skip to content

move_unpacked_nix: Read source directory all at once#1410

Merged
cole-h merged 1 commit intomainfrom
read-dir
Feb 5, 2025
Merged

move_unpacked_nix: Read source directory all at once#1410
cole-h merged 1 commit intomainfrom
read-dir

Conversation

@edolstra
Copy link
Contributor

@edolstra edolstra commented Feb 5, 2025

Description

Otherwise, at least on XFS, it's possible that we encounter store paths twice.

Should fix the failure seen in https://github.com/DeterminateSystems/nix-installer/actions/runs/13162433419/job/36734918342.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

Otherwise, at least on XFS, it's possible that we encounter store
paths twice.
@cole-h cole-h merged commit ea0f879 into main Feb 5, 2025
22 checks passed
@cole-h cole-h deleted the read-dir branch February 5, 2025 20:55
@cole-h cole-h added this to the 0.35.0 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants