Skip to content

Grahamc/fh 560 suggest dn#1415

Merged
grahamc merged 15 commits intomainfrom
grahamc/fh-560-prompt-for-dn
Feb 7, 2025
Merged

Grahamc/fh 560 suggest dn#1415
grahamc merged 15 commits intomainfrom
grahamc/fh-560-prompt-for-dn

Conversation

@grahamc
Copy link
Member

@grahamc grahamc commented Feb 7, 2025

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc grahamc added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Feb 7, 2025
@grahamc grahamc force-pushed the grahamc/fh-560-prompt-for-dn branch from 118244e to 5e15f90 Compare February 7, 2025 03:24
@grahamc
Copy link
Member Author

grahamc commented Feb 7, 2025

Closing until it is closer.

@grahamc grahamc closed this Feb 7, 2025
@grahamc grahamc reopened this Feb 7, 2025
Base automatically changed from ids-client to main February 7, 2025 16:43
@grahamc grahamc force-pushed the grahamc/fh-560-prompt-for-dn branch from d1ca3b4 to 9bb221f Compare February 7, 2025 16:55
@grahamc grahamc marked this pull request as ready for review February 7, 2025 19:38
@cole-h cole-h added this to the 0.36.0 milestone Feb 7, 2025
@grahamc grahamc merged commit 2542680 into main Feb 7, 2025
22 checks passed
@grahamc grahamc deleted the grahamc/fh-560-prompt-for-dn branch February 7, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants