Skip to content

CreateOrMergeNixConfig: handle existing, invalid nix.custom.conf contents#1439

Merged
cole-h merged 3 commits intomainfrom
cole/fh-619
Feb 14, 2025
Merged

CreateOrMergeNixConfig: handle existing, invalid nix.custom.conf contents#1439
cole-h merged 3 commits intomainfrom
cole/fh-619

Conversation

@cole-h
Copy link
Member

@cole-h cole-h commented Feb 14, 2025

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad to have that test, too 💪

@cole-h cole-h added this to the 0.36.4 milestone Feb 14, 2025
@cole-h cole-h enabled auto-merge (squash) February 14, 2025 18:55
@cole-h cole-h merged commit 7a51da5 into main Feb 14, 2025
22 checks passed
@cole-h cole-h deleted the cole/fh-619 branch February 14, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants