nix-installer: Create a workflow to propose new releases#1449
Merged
Conversation
grahamc
force-pushed
the
graham/fh-634-spaghetti-deploy
branch
from
5f907e7 to
0379f09
Compare
cole-h
reviewed
Feb 20, 2025
grahamc
commented
Feb 20, 2025
cole-h
approved these changes
Feb 20, 2025
grahamc
commented
Feb 20, 2025
cole-h
approved these changes
Feb 20, 2025
Comment on lines
+360
to
+363
| - version: in the `X.Y.Z` format. | ||
| No leading `v`. | ||
| - nix-version: The version of Nix to use in the flake.nix, in the format of `X.Y.Z`. | ||
| No leading `v`. |
Member
There was a problem hiding this comment.
Our tooling should be smart enough to strip out the excess leading vs, if any
Member
Author
There was a problem hiding this comment.
If it helps, it is smart enough to fail if it is invalid :)
grahamc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
draft, since I don't want to merge more than one at a time. Please review it as if it is ready to merge.
Checklist
cargo fmtnix buildnix flake checkValidating with
install.determinate.systemsIf a maintainer has added the
upload to s3label to this PR, it will become available for installation viainstall.determinate.systems: