Skip to content

Explicitly create /nix folder on installation #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Explicitly create /nix folder on installation #1523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/action/common/create_nix_tree.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use crate::action::{
};

const PATHS: &[&str] = &[
"/nix",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to do it as part of CreateNixTree, as that happens before we hit the revert for nix.mount, etc in the ostree planner, which will probably cause issues.

We'll probably want to create something similar to RevertCleanSteamosNixOffload for the ostree planner that does nothing in execute, but deletes /nix in revert, and have it be one of the first steps in the plan (so it's one of the last steps to be reverted upon uninstall).

"/nix/var",
"/nix/var/log",
"/nix/var/log/nix",
Expand Down