Skip to content

Re-base the nix-installer.sh against rustup's .sh #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Re-base the nix-installer.sh against rustup's .sh #1639

wants to merge 3 commits into from
+131 −71

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Aug 25, 2025 •
edited
Loading

Description

Reapplied after syncing the install script against the rustup script

ref rust-lang/rustup#4457

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

cole-h
cole-h reviewed Aug 25, 2025
View reviewed changes
@grahamc grahamc force-pushed the graham/fh-990-last-week-we-saw-the-determinate-nix-installer-hung-in-ci branch from a043519 to 11d02aa Compare August 25, 2025 16:53
@grahamc grahamc added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Aug 25, 2025
@grahamc grahamc changed the title Graham/fh 990 last week we saw the determinate nix installer hung in ci Re-base the nix-installer.sh against rustup's .sh Aug 25, 2025
@grahamc grahamc force-pushed the graham/fh-990-last-week-we-saw-the-determinate-nix-installer-hung-in-ci branch from 11d02aa to 459edd2 Compare August 25, 2025 17:09
@grahamc grahamc closed this Aug 26, 2025
@grahamc grahamc deleted the graham/fh-990-last-week-we-saw-the-determinate-nix-installer-hung-in-ci branch September 2, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

No one assigned

Labels

upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grahamc @cole-h