Skip to content

Remove OSTree Support Claim#1797

Open
indolering wants to merge 1 commit intoDeterminateSystems:mainfrom
indolering:patch-1
Open

Remove OSTree Support Claim#1797
indolering wants to merge 1 commit intoDeterminateSystems:mainfrom
indolering:patch-1

Conversation

@indolering
Copy link
Copy Markdown

@indolering indolering commented Mar 14, 2026

Installer does not currently work on most OSTree distributions with known workarounds breaking. It seems that upstream work needs to be done 1, 2.

Summary by CodeRabbit

  • Documentation
    • Simplified feature description in README for improved clarity.

Installer does not currently work on [most OSTree distributions](DeterminateSystems#1682) with [known workarounds breaking](DeterminateSystems#1596 (comment)).  It seems that upstream work needs to be done [1](coreos/rpm-ostree#5554), [2](DeterminateSystems#1445).
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1c3635fc-c4f4-4cfa-bde2-b285ffbf4f54

📥 Commits

Reviewing files that changed from the base of the PR and between 2c98095 and 362eb17.

📒 Files selected for processing (1)
  • README.md

📝 Walkthrough

Walkthrough

A minor wording update to the README.md file removes "and OSTree-based" from a feature description, simplifying the text from mentioning both SELinux and OSTree-based distributions to SELinux distributions only.

Changes

Cohort / File(s) Summary
Documentation
README.md
Minor wording update: removed "and OSTree-based" from feature description line.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • grahamc

Poem

🐰 A word or two did hop away,
From OSTree's distant bay,
SELinux stands alone today,
More concise in every way! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove OSTree Support Claim' directly and accurately describes the main change: removing the OSTree mention from the README feature line due to known compatibility issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant