builtins.wasm: Check against values with ID 0

[edolstra]

Motivation

Context

Summary by CodeRabbit

• Bug Fixes
  • Improved internal validation to prevent potential edge cases with value retrieval.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A condition in NixWasmInstance::getValue was tightened to reject id == 0 as invalid, in addition to the existing boundary check for id >= values.size(). This single-line modification prevents retrieval of values using ID 0.

Changes

Cohort / File(s)	Summary
WASM Value Validation src/libexpr/primops/wasm.cc	Tightened condition in getValue method to treat id == 0 as an invalid identifier alongside the existing size boundary check

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A single line hops into place,
Zero now knows its rightful disgrace,
Boundaries tighten, validation stands tall,
One tiny condition protects them all! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'builtins.wasm: Check against values with ID 0' clearly and specifically describes the main change: tightening a condition to treat id == 0 as invalid in the wasm module.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Deployed on https://6973623edb70c3fe9cedb769--determinate-nix.netlify.app