Skip to content

fix: mark SSE connection as connected when Comment events are received #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luxscious merged 2 commits into from
Dec 4, 2025
Merged

fix: mark SSE connection as connected when Comment events are received #104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc8fd36
fix: add elif to handle comment events from ldevents library
luxscious Dec 4, 2025
21bc474
chore:update to handleState none to just set the connected state
luxscious Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions devcycle_python_sdk/managers/sse_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ def read_events(
handle_error(event)
elif isinstance(event, ld_eventsource.actions.Event):
handle_message(event)
elif isinstance(event, ld_eventsource.actions.Comment):
handle_message(event)
except Exception as e:
logger.debug(f"DevCycle: failed to read SSE message: {e}")

Expand Down
2 changes: 1 addition & 1 deletion devcycle_python_sdk/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def __init__(
self,
config_cdn_uri: str = "https://config-cdn.devcycle.com/",
config_request_timeout_ms: int = 5000,
config_polling_interval_ms: int = 1000,
config_polling_interval_ms: int = 30000,
config_retry_delay_ms: int = 200, # milliseconds
on_client_initialized: Optional[Callable] = None,
events_api_uri: str = "https://events.devcycle.com/",
Expand Down
Loading