Skip to content

fix: Expecting seconds to be passed in - API returns millis. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamieSinn merged 2 commits into from
Feb 11, 2025
Merged

fix: Expecting seconds to be passed in - API returns millis. #81

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29afef9
Expecting seconds to be passed in - API returns millis.
JamieSinn Feb 11, 2025
a36a68b
lint
JamieSinn Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devcycle_python_sdk/managers/config_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def sse_message(self, message: ld_eventsource.actions.Event):
or dvc_data.get("type") is None
):
logger.info("DevCycle: Received refetchConfig message - updating config")
self._get_config(dvc_data["lastModified"])
self._get_config(dvc_data["lastModified"]/1000)

def sse_error(self, error: ld_eventsource.actions.Fault):
logger.warning(f"DevCycle: Received SSE error: {error}")
Expand Down
Loading