Collection.Base: convert to ES6 Class#28762
Merged
EugeniyKiyashko merged 1 commit intoDevExpress:25_1from Jan 21, 2025
Merged
Conversation
EugeniyKiyashko
force-pushed
the
25_1_move_collection_base_to_native_class
branch
8 times, most recently
from
6f41c14 to
a6e9edd
Compare
EugeniyKiyashko
force-pushed
the
25_1_move_collection_base_to_native_class
branch
from
a6e9edd to
7f560f0
Compare
ksercs
reviewed
Jan 21, 2025
| private readonly _feedbackHideTimeout = 400; | ||
| public _activeStateUnit!: string; | ||
|
|
||
| public _feedbackHideTimeout = 400; |
Contributor
Author
There was a problem hiding this comment.
Because _feedbackHideTimeout overrides inside the children
ksercs
reviewed
Jan 21, 2025
| args: ItemRenderInfo<TItem>, | ||
| ): ItemTemplate<TItem> { | ||
| const data = args.itemData; | ||
| // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing |
Contributor
There was a problem hiding this comment.
Why did u fix this error somewhere and ignored it in other places?
Contributor
Author
There was a problem hiding this comment.
Because I am not sure there will be no breaking changes in these places, I would prefer to deal with it separately
ksercs
approved these changes
Jan 21, 2025
marker-dao
approved these changes
Jan 21, 2025
anna-shakhova
approved these changes
Jan 21, 2025
| _isFocusTarget(element: Element | undefined): boolean { | ||
| const focusTargets = $(this._focusTarget()).toArray(); | ||
| // @ts-expect-error ts-error | ||
| return focusTargets.includes(element); |
Contributor
There was a problem hiding this comment.
Let's fix error instead of muting
Suggested change
| return focusTargets.includes(element); | |
| return !!element && focusTargets.includes(element); |
Contributor
Author
There was a problem hiding this comment.
I'll consider in the further PRs
| } | ||
|
|
||
| _isFocusTarget(element: Element): boolean { | ||
| _isFocusTarget(element: Element | undefined): boolean { |
Contributor
There was a problem hiding this comment.
Suggestion: we can use shorter form
Suggested change
| _isFocusTarget(element: Element | undefined): boolean { | |
| _isFocusTarget(element?: Element): boolean { |
Contributor
Author
There was a problem hiding this comment.
I'll consider in the further PRs
EugeniyKiyashko
added a commit
to EugeniyKiyashko/DevExtreme
that referenced
this pull request
Jan 21, 2025
EugeniyKiyashko
added a commit
that referenced
this pull request
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.