CardView: editing operations, add/edit/delete (throw error if needed) (Gv6qwVwI)#29879
Merged
haksur merged 16 commits intoDevExpress:25_1from May 21, 2025
Merged
CardView: editing operations, add/edit/delete (throw error if needed) (Gv6qwVwI)#29879haksur merged 16 commits intoDevExpress:25_1from
haksur merged 16 commits intoDevExpress:25_1from
Conversation
haksur
changed the title
haksur
force-pushed
the
fix/cardView-editing-error
branch
from
f072d60 to
90e6232
Compare
haksur
force-pushed
the
fix/cardView-editing-error
branch
from
90e6232 to
5e6ac1d
Compare
haksur
changed the title
wdevfx
reviewed
May 16, 2025
packages/devextreme/js/__internal/grids/new/card_view/widget.test.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/new/card_view/widget.test.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/new/grid_core/editing/controller.ts
Outdated
Show resolved
Hide resolved
…mments fixes, updated solution, added more tests, created options_validation)
…to fix/cardView-editing-error
… (Gv6qwVwI) (review comments fixes)
… (Gv6qwVwI) (import fix)
…to fix/cardView-editing-error
…ew-editing-error # Conflicts: # packages/devextreme/js/__internal/grids/new/grid_core/di.ts # packages/devextreme/js/__internal/grids/new/grid_core/options_validation/controller.ts # packages/devextreme/js/__internal/grids/new/grid_core/selection/controller.test.ts # packages/devextreme/js/__internal/grids/new/grid_core/selection/controller.ts
… (Gv6qwVwI) (updated tests)
… (Gv6qwVwI) (removed unnecessary changes that left after merge conflict fix)
… (Gv6qwVwI) (change import in controller)
… (Gv6qwVwI) (fix test)
… (Gv6qwVwI) (changed tests to integration)
… (Gv6qwVwI) (fix tests)
wdevfx
approved these changes
May 21, 2025
GoodDayForSurf
pushed a commit
to GoodDayForSurf/DevExtreme
that referenced
this pull request
May 22, 2025
ajivanyandev
pushed a commit
that referenced
this pull request
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.